PrismarineJS / PrismarineJS/minecraft-data
Incorrect sound ID mapping for all versions
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 938
- Forks
- 294
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 25
Description
I just switched to using sound map from mc-data and I see it is mostly ok, but still incorrect for 1.20.4. For example:
Sound with ID 944 must be block.note_block.flute not block.note_block.guitar:
https://github.com/PrismarineJS/minecraft-data/blob/8a8c811c71790d75ec405429e5b50343cb77f88b/data/pc/1.20.4/sounds.json#L3774-L3781
@wgaylord
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with data/pc/1.20.4/sounds.json and inspect the mapping around the reported ID 944. Compare the versioned sound maps for the same ID and verify the expected sound names; done means the affected mappings are corrected consistently across supported versions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100