PrismarineJS / PrismarineJS/minecraft-data

[1.20.2] Incorrect recipes, and inconsistent shape format

Open
#797 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
938
Forks
294
Avg merge
2d 10h
Merged PRs (30d)
23

Description

Noticed that the crafting table recipe is wrong - describes it as an L shape instead of a square:

    {
      "inShape": [
        [ 23, 23, 23 ], 
        [ 23, null, null ]
      ],
      "result": {
        "id": 278,
        "count": 1
      }
    }

Haven't found any other incorrect recipes, but there may be more.

Secondly, there's an inconsistency with the format of recipe shapes - some recipes define each array as a "row" in the crafting grid, e.g Sandstone Wall:

      "inShape": [
        [ 169, 169, 169 ],
        [ 169, 169, 169 ]
      ]

image

But then for a Redstone Torch, each array is a "column":

      "inShape": [
        [
          635,
          807,
          null
        ]
      ]

image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue identifies crafting recipe data but does not name a file or test. Start by locating the recipe definitions for the crafting table, Sandstone Wall, and Redstone Torch, then inspect other recipes for the same shape convention. Done means the crafting table shape is correct and recipe arrays consistently represent rows or columns.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.