PrismarineJS / PrismarineJS/minecraft-data

1.8 enchantments exclude field includes enchantments not in 1.8

Open
#582 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

pc
Dominant language
JavaScript
Stars
938
Forks
294
Avg merge
2d 10h
Merged PRs (30d)
23

Description

In the enchantments json of 1.8, the "exclude" field sometimes includes enchantments that are not in 1.8. (e.g. frost walker)
I don't think this is intentional and it makes it annoying to write code generation tools that use this.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the enchantments JSON for version 1.8 and compare each entry in the "exclude" field with the enchantments available in 1.8. Remove entries that belong to later versions, such as frost walker, and verify that the resulting data no longer includes out-of-version enchantments.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.