PrismarineJS / PrismarineJS/minecraft-data

Proposal: Remove materials.json and putting the important data in blocks.json

Open
#557 3 comments 1 reaction 1 assignee View on GitHub

Nobody has claimed this yet.

pc
Dominant language
JavaScript
Stars
938
Forks
294
Avg merge
2d 10h
Merged PRs (30d)
23

Description

What happens now?

As of 1.17, the digtime function in prismarine-block uses the materials.json to get the effective data.

Why should it be changed?

As of 1.17, there are a lot more categories than the much more primitive ones that were there when the materials file was created, see:
1.16 materials.json
1.17 materials.json

What would change?

This would allow for getting rid of the harvestTools data on each block and the material type on each block, as this would be part of the new tool_speeds object on each block.

Open to input on anything that should be changed

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.