PrismarineJS / PrismarineJS/minecraft-data

Wrong play.entity_equipment packet definition for version 1.18.1

Open
#520 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

pc
Dominant language
JavaScript
Stars
938
Forks
294
Avg merge
2d 10h
Merged PRs (30d)
23

Description

When trying to reproduce the entity_equipment packet node-minecraft-protocol failes. @u9g suggested that the packet definition is wrong.

Steps to reproduce:
Launch the node-minecraft-protocol (proxy)[https://github.com/PrismarineJS/node-minecraft-protocol/tree/master/examples/proxy] example for version 1.18.1.
The proxy will print the error in console. The produced packet is shorter then the initially read packet. The client will also crash if this packet is send. Therefor the assumption that the packet is mall formed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the node-minecraft-protocol proxy example linked in the issue and reproduce the entity_equipment packet failure for Minecraft 1.18.1. Compare the produced packet with the initially read packet and verify that the corrected definition no longer causes a shortened packet or client crash.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.