PrismLibrary / PrismLibrary/Prism

DirectoryModuleCatalog contains a large number of outdated APIs

Open
#2,931 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C#
Stars
6.8k
Forks
1.6k
Avg merge
2d 1h
Merged PRs (30d)
1

Description

Summary

https://github.com/PrismLibrary/Prism/blob/bf0966af97a7dd16141ed3b3c3cfc784ff5e0cb7/src/Wpf/Prism.Wpf/Modularity/DirectoryModuleCatalog.netcore.cs#L139

assembly.ReflectionOnlyLoadFrom(dependentAssemblyFilename);

API Changes

assembly.load(dependentAssemblyFilename);

The recommended method for loading DLLs in. net core is AssemblyContextLoad. Would you like to consider changing AppDomain to AssemblyContextLoad in the future?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/Wpf/Prism.Wpf/Modularity/DirectoryModuleCatalog.netcore.cs at the referenced line and review how dependent assemblies are loaded. Compare the current ReflectionOnlyLoadFrom/AppDomain-related APIs with the issue's proposed AssemblyContextLoad approach, then verify the catalog's assembly-loading behavior with the relevant existing tests, if present.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.