PrismLibrary / PrismLibrary/Prism
AddGlobalNavigationObserver for change of tabs in a tabbed page
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 6.8k
- Forks
- 1.6k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 1
Description
Discussed in https://github.com/PrismLibrary/Prism/discussions/2853
Originally posted by Natpraveen March 30, 2023
We could see the AddGlobalNavigationObserver observables getting called on creation of the tabs. But when we switch between the tabs the observables are not getting called.
Believe making the existing observable to fire or having a separate observable for tab changes would help having these information in a single place.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names AddGlobalNavigationObserver and its observables but no file or test. Start by locating that entry point and tracing tab creation versus tab switching in the tabbed-page navigation flow. Done means the chosen observable behavior consistently exposes tab changes, with the expected behavior decided between updating the existing observable and adding a separate one.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100