PrismJS / PrismJS/prism

[v2] Remove `KnownPlugins` data structure

Open
#3,903 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
13k
Forks
1.4k
Avg merge
15h 36m
Merged PRs (30d)
3

Description

Having a data structure about known plugins is completely contrary to the idea of plugins. The core should not know anything about plugins, the dependency goes the other way. Even for core plugins, if the core needs to know about them, what's the point of making them plugins?

If it's a TS issue, the plugins should amend types in the plugin, it should not go the other way.

I suspect this is yet another instance where TS introduces more problems than it solves…

@RunDevelopment let me know if I'm missing context!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating references to KnownPlugins and tracing the TypeScript dependencies between core and plugins; done means the core no longer maintains a known-plugin data structure or depends on plugin-specific knowledge.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.