tabindex on all pre tag, should allow opt-in or opt-out
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 13k
- Forks
- 1.4k
- Avg merge
- 15h 36m
- Merged PRs (30d)
- 3
Description
both: components/prism-core.js and prism.js contain these problematic tabindex injections
if (parent && parent.nodeName.toLowerCase() === 'pre' && !parent.hasAttribute('tabindex')) {
parent.setAttribute('tabindex', '0');
}
if code-snippets have actions such as copy, edit, delete those should have buttons or be in a dropdown control that has an implicit native tabindex
at least allow people to opt out of adding tabindexes to non interactive code-snippets as of now someone has to add a tabindex of -1 to optout
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the tabindex injection in components/prism-core.js and prism.js. Determine how an opt-in or opt-out should prevent tabindex="0" on non-interactive pre elements while preserving the intended behavior for interactive snippets. Done means the behavior is configurable and the unwanted automatic tabindex can be avoided.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- accessibility
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100