async + defer can result in DOMContentLoaded not being fired
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 13k
- Forks
- 1.4k
- Avg merge
- 15h 36m
- Merged PRs (30d)
- 3
Description
Information:
- Prism version: 1.28.0
- Plugins:
languages=markup+css+clike+javascript+bash+css-extras+git+go+java+json+json5+makefile+markdown+markup-templating+php+regex+shell-session+sql+iecst+typescript+yaml - Environment: browser
Description
When loading the script with async and defer, the automatic highlighting doesn't always work.
I think this is due to readystate === interactive and it seems that DOMContentLoaded will not fire when that is the case.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the browser case with Prism loaded using both async and defer, then inspect the automatic highlighting path and its DOMContentLoaded/readystate handling. Done means automatic highlighting works reliably in this loading configuration without preventing DOMContentLoaded from firing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100