PrismJS / PrismJS/prism

Swift enum with associated values incorrect highlighting

Open
#2,023 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug language-definitions
Dominant language
JavaScript
Stars
13k
Forks
1.4k
Avg merge
15h 36m
Merged PRs (30d)
3

Description

Information

  • Language: Swift
  • Plugins: none

Does the problem still occur in the latest version of Prism? You can check using the test page or get the latest version at the download page.

Yes, the problem still occurs in the latest version of Prism.

Description
An enum with associated values has its cases incorrectly interpreted as a function token, which is a problem when an enum has a case with one associated value and an empty case.

Incorrect:
Incorrectly rendered Swift enum
Correct:
Correctly rendered Swift enum

All of the cases should have the same color.

Code snippet

The code being highlighted incorrectly.
public enum Event<Element> {
    case next(Element)
    case error(Error)
    case completed
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Use the Swift example in the issue with Prism's test page to reproduce the highlighting. Investigate how the enum cases are tokenized and verify that next(Element), error(Error), and completed receive the same color when the fix is complete.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.