PrismJS / PrismJS/prism

Can we use Element.classList or not?

Open
#1,815 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

plugins
Dominant language
JavaScript
Stars
13k
Forks
1.4k
Avg merge
15h 36m
Merged PRs (30d)
3

Description

I just want to ask whether we use Element.classList or not. Cross-browser support is not perfect but it should be good enough.

I'm asking because I thought that we don't use .classList but plugins like Line numbers are sending mixed messages, so I'm not sure.

/cc @mAAdhaTTah

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the plugin code at plugins/line-numbers/prism-line-numbers.js, especially the references around lines 88 and 147. Determine whether Element.classList is supported for project code and plugins, then document the decision and any resulting guidance for class manipulation.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.