PrismJS / PrismJS/prism

Line number mark and highlighted background isn't placed at specified line

Open
#1,669 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
13k
Forks
1.4k
Avg merge
15h 36m
Merged PRs (30d)
3

Description

Using data-line attribute without class="line-numbers" attribute at <pre> tag, prism shows line numbers mark(s) and highlighted background. But the mark and highlighted background are not placed specified line.

Sample post is below(please look at lower source code box) :
http://red-souls.jp/ichounoki/rnote/software/20181216_042333932863.htm

I wrote the pre tag for upper source code box in the post as below :

<pre class="line-numbers" data-line="17" style="max-height: calc(16px0.81.5*31);">

I specified line number 17 for highlight, but the mark and highlighted line (yellow) is drawn at almost line number 19. For some reason, the position for draw shifts.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue from the linked sample post, focusing on the

 markup with data-line="17" and the line-numbers class. Compare the mark and highlighted background with the requested line, then confirm the fix against the same example and ensure the offset no longer occurs.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.