Show Invisibles: Problems with modifying grammars
Open
Nobody has claimed this yet.
bug
plugins
- Dominant language
- JavaScript
- Stars
- 13k
- Forks
- 1.4k
- Avg merge
- 15h 36m
- Merged PRs (30d)
- 3
Description
Because Show Invisibles modifies the language definition itself, there might be problems with:
- The
restproperty is "unfolded" after we add the patterns for ICs which results in the tokens ofrestbeing highlighted after the IC tokens. - Other plugins (e.g. Autolinker) also modify language definitions at run-time (meaning via hooks). Show Invisibles has to be run after these plugins to be compatible. (#1612)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the Show Invisibles and Autolinker plugin hooks and how language definitions are modified at runtime. Reproduce the rest token-ordering issue and the plugin-ordering interaction described here; done means both highlighting behaviors are compatible without requiring an undocumented execution order.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100