What is the difference and relationship between PositionColumn and DraggableColumn ?
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 136
- Forks
- 555
- Avg merge
- 4d 14h
- Merged PRs (30d)
- 4
Description
It seems we have 2 columns that serve somehow the same purpose.
PrestaShop\PrestaShop\Core\Grid\Column\Type\Common\PositionColumnPrestaShop\PrestaShop\Core\Grid\Column\Type\Common\DraggableColumn
On CMS pages listing, PositionColumn is used alone and provides the desired behavior (= have a drag-and-droppable "position" column).
On Category listing, DraggableColumn is used with CategoryPositionColumn to provide the desired behavior.
Looks like duplicated logic needing refactoring.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare PrestaShop\PrestaShop\Core\Grid\Column\Type\Common\PositionColumn and DraggableColumn, then inspect their use in the CMS and Category listings. Establish whether their behavior is genuinely duplicated and identify the intended shared design; the issue is done when the relationship and refactoring scope are resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100