PrestaShop / PrestaShop/docs

A second fieldset with tabs shows broken on a module configuration page

Open
#557 8 comments 0 reactions 1 assignee View on GitHub

@Matt75 is already working on this.

Since Jun 4, 2020.

Dominant language
Scala
Stars
136
Forks
555
Avg merge
4d 14h
Merged PRs (30d)
4

Description

Describe the bug

If you add a second fieldset with tabs on a module's configuration page, the first its ok but the second ones its broken.

this are the ids for the panels:

<div class="panel" id="fieldset_0">
...
<div class="panel" id="fieldset_1_1">
...

https://github.com/PrestaShop/PrestaShop/blob/12177c5efaad9abaf8fca5c669f4c0026ee4114a/admin-dev/themes/default/template/helpers/form/form.tpl#L48

the javascript that makes the tabs in the second case is searching for a wrong id:

$('#'+unique_field_id+'fieldset_'+index+' .form-wrapper')

https://github.com/PrestaShop/PrestaShop/blob/12177c5efaad9abaf8fca5c669f4c0026ee4114a/js/admin.js#L684-L687

  • PrestaShop version: 1.7.6.5

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.