PrestaShop / PrestaShop/TranslationToolsBundle

[EPIC] TranslationToolsBundle compatibility with Twig v1, v2 and v3

Open
#89 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
5
Forks
21
PR merge metrics
No merged PRs in 30d

Description

Thanks to @atomiix and @sowbiba tests, it has been confirmed that TranslationToolsBundle is not fully compatible with Twig v2 and Twig v3 although the composer.json states so.

It also seems that it will be hard to maintain compatibility with the 3 versions of Twig, given breaking changes between v1 and v2 and v3 and v3.

If this is confirmed, we might need to have TranslationToolsBundle v4 compatible with Twig 1, and TranslationToolsBundle v5 compatible with Twig 3 and maybe 2. TranslationToolsBundle v4 would be used in PrestaShop 1.7.x until 1.7.8 and TranslationToolsBundle v5 would be used in more recent PrestaShop versions.

This means we should keep a branch 4.x open to be able to release patch versions of TranslationToolsBundle v4.

TODO

  1. https://github.com/PrestaShop/TranslationToolsBundle/issues/90
  2. https://github.com/PrestaShop/TranslationToolsBundle/issues/91
  3. https://github.com/PrestaShop/TranslationToolsBundle/issues/92
  4. https://github.com/PrestaShop/TranslationToolsBundle/issues/93

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with composer.json and the compatibility findings linked in issues #90, #91, #92, and #93. Review the TranslationToolsBundle versioning proposal and determine whether separate 4.x and 5.x compatibility lines are required; done means the Twig compatibility plan and related TODOs are resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, symfony
Domain
localization
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.