PrestaShop / PrestaShop/PrestaShop
Separate multi store email logo does not get picked up
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 9.2k
- Forks
- 5k
- Avg merge
- 2d 20h
- Merged PRs (30d)
- 53
Description
Prerequisites
- I understand and accept the project's code of conduct.
- I have already searched in existing issues and found no previous report of this bug.
Describe the bug and add attachments
Bug in PrestaShop 8.0 which is already fixed in develop. Fix:
https://github.com/PrestaShop/PrestaShop/commit/429189083e0f4dc872b2b1a8952af99eec4c96f9
From the commit message:
When emails are sent with a specific $id_shop in parameter, if a different PS_LOGO_MAIL is configured for this shop it won't be used because Configuration::get uses the contextualised shop to check if a specific LOGO_EMAIL exists
Can this be fixed in PS 8.0 also please?
Shouldn't PS 8.0 get all relevant upstream bug fixes automatically?
Expected behavior
No response
Steps to reproduce
Setup multi store environment with different logos and send mails
PrestaShop version(s) where the bug happened
8.0
PHP version(s) where the bug happened
8.1
If your bug is related to a module, specify its name and its version
No response
Your company or customer's name goes here (if applicable).
headissue GmbH
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the linked upstream commit and the Configuration::get path, focusing on how PS_LOGO_MAIL is resolved when an email uses a specific id_shop. Reproduce the issue in a multistore setup with different logos and send emails for each shop. Done means the shop-specific email logo is selected on the 8.0 branch as it is in develop.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100