PowerShell / PowerShell/vscode-powershell

Extension overwrites native colors of the theme

Open
#2,959 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Semantic Highlighting Area-UI Issue-Discussion
Dominant language
TypeScript
Stars
1.9k
Forks
547
PR merge metrics
No merged PRs in 30d

Description

Issue Description

So I updated to the newest version thinking it would solve the issue with theme colors being all green, and partially it did. But only partially. It's still green, just a bit less of it

image

This is native theme:

image

I get that there may be a difference between how theme highlights colors and how extension highlight colors but it should use theme colors, not just overwrite with predefined color set.

And to be honest it seems highlighting is better in theme, then by extension (ValueFromPipeline/Mandatory) gets additional highlighting. Same for $null.

Attached Logs

Follow the instructions in the README about
capturing and sending logs.

Environment Information

Visual Studio Code

Name Version
Operating System Windows_NT x64 10.0.19042
VSCode 1.49.0
PowerShell Extension Version 2020.9.0

PowerShell Information

Name Value
PSVersion 5.1.19041.1
PSEdition Desktop
PSCompatibleVersions 1.0 2.0 3.0 4.0 5.0 5.1.19041.1
BuildVersion 10.0.19041.1
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1

Visual Studio Code Extensions

Visual Studio Code Extensions(Click to Expand)
Extension Author Version
better-toml bungcip 0.3.2
errorlens usernamehw 3.2.1
github-linker gimenete 0.2.3
gitlens eamodio 10.2.2
line-endings steditor 1.0.3
markdown-all-in-one yzhang 3.3.0
material-icon-theme PKief 4.3.0
open-in-browser techer 2.0.0
powershell-preview ms-vscode 2020.9.0
project-manager alefragnani 11.3.0
rainbow-brackets 2gua 0.0.6
run-in-powershell tobysmith568 1.1.0
swdc-vscode softwaredotcom 2.3.11
vscode-markdownlint DavidAnson 0.36.3
vscode-toggle-quotes BriteSnow 0.3.3
vscode-wakatime WakaTime 4.0.8
vscode-yaml redhat 0.10.1
xml DotJoshJohnson 2.5.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the color behavior in Visual Studio Code with the PowerShell extension and the theme described in the issue. Read the troubleshooting guidance in docs/troubleshooting.md if logs are needed. Done means native theme colors remain intact while PowerShell-specific highlighting, including parameter attributes and $null, still works.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell, typescript, vscode
Domain
devtools, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.