PowerShell / PowerShell/vscode-powershell

integrated console starts immediately if untitled editor is reloaded

Open
#1,420 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Extension Terminal Issue-Enhancement
Dominant language
TypeScript
Stars
1.9k
Forks
547
PR merge metrics
No merged PRs in 30d

Description

Issue Type: Bug

Start VSCode with PowerShell extension enabled, with an untitled and dirty PowerShell editor reloaded from hot-exit, but not restarted with the focus (so other editors that are not PowerShell must be also reloaded from hot-exit), and the PowerShell integrated console starts immediately (as soon as extensions start), with its 'starting' status and later the icon appearing in the status bar, even though its unwarranted. This only seems to happen while there is an untitled PowerShell language mode editor that is also dirty, restarted via hot-exit, without it being in focus. (Integrated console starting is expected if any editor in PowerShell language mode restarts with the focus)

image

image

Examples above are with an also untitled dirty SQL language file reloaded with the focus. I can however confirm that it also occurs if a saved and not dirty file is reloaded with the focus, such as Batch:

image

Extension version: 1.8.0
VS Code version: Code 1.25.0 (0f080e5267e829de46638128001aeb7ca2d6d50e, 2018-07-05T13:11:58.697Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i5 CPU U 430 @ 1.20GHz (4 x 1197)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: unavailable_software
video_decode: enabled
video_encode: enabled
vpx_decode: unavailable_software
webgl: enabled
webgl2: enabled
Memory (System) 1.74GB (0.66GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the VS Code hot-exit scenario described in the issue with a dirty untitled PowerShell editor and another editor focused. Trace the extension startup and integrated-console activation path; done means the console remains stopped when the PowerShell editor is not restored with focus, while still starting when it is focused.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell, typescript, vscode
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.