PowerShell / PowerShell/vscode-powershell

Put the setLanguageConfiguration code in the appropriate place

Open
#1,349 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Configuration Issue-Discussion
Dominant language
TypeScript
Stars
1.9k
Forks
547
PR merge metrics
No merged PRs in 30d

Description

Currently main.ts is mostly populated with this mystifying code blob:
https://github.com/PowerShell/vscode-powershell/blob/6c96a2d56b9593a25e6960df2c6f3767b3d30177/src/main.ts#L53-L104

It seems to have some PowerShell related bits in it, but also some JS doc comment stuff...

It probably shouldn't be in main.ts, and we should work out if it even causes anything. I suspect it's getting ignored in favour of the code in https://github.com/Microsoft/vscode/blob/master/extensions/powershell/language-configuration.json.

We should investigate and:

  • if the code here is being preferred, move it to a more sensible location in the repo and make sure it's up to do
  • if the VSCode JSON is being preferred, delete this code

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the setLanguageConfiguration code in src/main.ts at the linked lines, then compare it with the VS Code language-configuration.json referenced in the issue. Determine which configuration is used and whether the TypeScript code has an effect. Done means either moving and updating the code in a more suitable location, or removing it if the JSON is preferred.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell, typescript, vscode
Domain
tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.