PowerShell / PowerShell/Win32-OpenSSH

STARTUPINFOW vs. STARTUPINFO

Open
#1,829 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
8.3k
Forks
819
PR merge metrics
No merged PRs in 30d

Description

https://github.com/PowerShell/openssh-portable/blob/8ab565c53f3619d6a1f5ac229e212cad8a52852c/contrib/win32/win32compat/win32_pty.c#L83

That "should" be sizeof(STARTUPINFOW) or better yet sizeof(si).
.I realize it probably makes no difference, i.e. if the struct only contains pointers to char/WCHAR, and not any arrays, i.e. the size is the same.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open contrib/win32/win32compat/win32_pty.c at line 83 and inspect the STARTUPINFO declaration and the size passed there. Update the size expression to use STARTUPINFOW or the declared variable, then confirm the Windows compatibility code still builds and the size matches the intended structure.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
operating-systems
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.