PowerShell / PowerShell/PowerShellEditorServices
Move prompt gathering out of GetSessionDetails
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 767
- Forks
- 266
- Avg merge
- 3d 16h
- Merged PRs (30d)
- 1
Description
When I introduced the concept of gathering session details after each command that gets run, I rolled prompt gathering into that to avoid running yet another command each time a prompt is needed. It seems that this causes more problems than necessary because a prompt function that throws errors does not get handled correctly anymore.
I'll move prompt gathering back out into the ConsoleService so that we can check for errors and return a default prompt appropriately.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating GetSessionDetails and ConsoleService, then trace where prompt gathering and prompt-function errors are handled. Move prompt gathering to ConsoleService and verify that prompt errors produce the default prompt as described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, powershell
- Domain
- developer-experience, tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100