PowerShell / PowerShell/PowerShell
Remove unneeded checks in Wix installer for WinRM prereqs or change link
Open
Nobody has claimed this yet.
Needs-Triage
- Dominant language
- C#
- Stars
- 55.5k
- Forks
- 8.5k
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 88
Description
Prerequisites
- Write a descriptive title.
- Make sure you are able to repro it on the latest released version
- Search the existing issues.
- Refer to the FAQ.
- Refer to Differences between Windows PowerShell 5.1 and PowerShell.
Steps to reproduce
There are two checks in the Wix for WinRM prerequisites.
- The first checks for the Universal C Runtime.
- The second checks for the pwrshplugin.dll with MinVersion="6.3.9600.16383"
For both of these checks, the installer displays the message: "You can find download links here: https://aka.ms/pscore6-prereq"
- Those prerequisites are automatically met for all versions of Windows that we currently support. So the checks are no longer needed.
- This aka.ms link is outdated (PS6) and takes you to the Windows install article that no longer links to any of the downloads mentioned in the message.
Expected behavior
These messages should never appear, but the outdated code should be removed.
Actual behavior
Suggested changes
- Remove the unneeded checks and retire the aka.ms link
OR
- Change the aka.ms link to point to <https://www.microsoft.com/en-us/download/details.aspx?id=48234>, which is the download link for the Univeral C Runtime.
Error details
No response
Environment data
Name Value
---- -----
PSVersion 7.4.0
PSEdition Core
GitCommitId 7.4.0
OS Microsoft Windows 10.0.22621
Platform Win32NT
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0
Visuals
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with assets/wix/Product.wxs around lines 177-188 and inspect the two WinRM prerequisite checks and their outdated aka.ms message. Remove the unnecessary checks or update the link as appropriate, then verify that the installer no longer displays those prerequisite messages.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system, release
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100