PowerShell / PowerShell/PSScriptAnalyzer

Investigate/Fix test failure on PowerShell Core

Open
#944 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area - Build Area - Rules
Dominant language
C#
Stars
2.2k
Forks
414
Avg merge
13h 1m
Merged PRs (30d)
2

Description

  • The "suggests corrections for AliasesToExport with wildcard of UseManifestExportFields is currently set as pending when tests are being run using the coreclr.
    This tests needs to be looked into and possibly fixed.
    The test is here:
    https://github.com/PowerShell/PSScriptAnalyzer/blob/021711eae27a2bd00165f30c6c568a78f448870a/Tests/Rules/UseToExportFieldsInManifest.tests.ps1#L86
  • There are 9 test failures using PowerShell Core on Windows and Ubuntu but they do not fail in AppVeyor for some reason. Those tests were always failing, even when going back to an old commit like 9e37dd34e8564dc7470dda1e0d2596de37bcd679 in January. Therefore those failures are to be considered technical debt. Until we know why AppVeyor lets them pass and fix them afterwards, we have to more diligent with running tests locally or on VSTS using PowerShell Core to make sure that we do not introduce regression. The test failures are:
    pssa_corefailures1
    pssa_corefailures2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Tests/Rules/UseToExportFieldsInManifest.tests.ps1 at the referenced test and run the suite using PowerShell Core on Windows and Ubuntu. Compare the reported failures with AppVeyor results and determine whether the nine listed failures are test or environment issues. Done means the failures are explained and the affected tests are fixed or updated appropriately.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.