PowerShell / PowerShell/PSScriptAnalyzer

`PSUseDeclaredVarsMoreThanAssignments` and assigning multiple variables

Open
#2,164 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area - PSUseDeclaredVarsMoreThanAssignments Up-for-Grabs
Dominant language
C#
Stars
2.2k
Forks
414
Avg merge
13h 1m
Merged PRs (30d)
2

Description

Aside from the false positive issues with the PSUseDeclaredVarsMoreThanAssignments rule, it has also a false negative bug:

This concerns assigning multiple variables:

This (as the only script line), correctly reports a PSUseDeclaredVarsMoreThanAssignments volitation on $a:

$a = $null

But this doesn't:

$a, $b = $null

PSScriptAnalyzer version: 1.24.0

Name                           Value
----                           -----
PSVersion                      7.5.4
PSEdition                      Core
GitCommitId                    7.5.4
OS                             Microsoft Windows 10.0.26100
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the two PowerShell snippets and then trace the PSUseDeclaredVarsMoreThanAssignments rule's handling of multiple-variable assignments. Add regression coverage for the reported false negative and verify that the unused variable is reported as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
powershell
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.