PowerShell / PowerShell/PSScriptAnalyzer

Invoke-ScriptAnalyzer does not validate suppressed rule names in code

Open
#1,666 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue - Enhancement Up-for-Grabs
Dominant language
C#
Stars
2.2k
Forks
414
Avg merge
13h 1m
Merged PRs (30d)
2

Description

I just spent an hour trying to figure out why my suppressed rule in script is not working only to notice a trailing space at the end of the rule name.

[Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseShouldProcessForStateChangingFunctions ', '',Justification = "Does not change any states")]

If Invoke-ScriptAnalyzer can validate that all suppressed rule names are valid that would save some troubleshooting time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Invoke-ScriptAnalyzer handling of SuppressMessageAttribute and trace how suppressed rule names are processed. Confirm how the analyzer reports invalid names, then add coverage for the trailing-space example so the invalid suppression is surfaced.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, powershell
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.