Consider merging ForwardDeleteLine and DeleteToEnd

Open

#2,144 opened on Jan 19, 2021 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 3/5
Estimated time: 1-2 days
Newbie friendliness: 38/100

Issue type: Refactor
Clarity: Mostly clear
Activity status: Stale
Tech stack: csharp
Domain: cli

Research direction

Start by reading the ForwardDeleteLine and DeleteToEnd methods, including the change introduced by #2002, and compare their handling of deletion to the logical line end. Determine which implementation can be shared without changing normal or VI-mode behavior. Done means the duplicated logic is merged into a common method and both commands retain their existing behavior.

Written by the indexing model from the issue text.

Description

Issue-Enhancement Issue-Triaged

Description of the new feature/enhancement

Starting from #2002, the ForwardDeleteLine deletes a portion of text from the cursor to the end of the current logical line.
The DeleteToEnd method is used in VI-mode to perform the same operation.

Consider merging (part of) both implementations to a common method.

Dominant language: C#
Stars: 4.4k
Forks: 341
PR merge metrics: No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.