PowerShell grammar categorizing member values differently.

Open
#160 15 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
powershell, vscode
Domain
tooling

Research direction

Compare the older and newer PowerShell grammar classifications for the reported Name member, using the VS Code no-extension reproduction described in the issue. Check the related comment discussion for an agreed intended scope, then confirm whether the grammar or theme behavior should change and verify the resulting classification in VS Code.

Written by the indexing model from the issue text.

Description

From @cblackuk on February 18, 2019 10:16

  • VSCode Version: >1.27.2
  • OS Version: Win10, 2016, 2019 - does not matter

Steps to Reproduce:

On VSC with no extensions 1.27.2, using an older version of the PowerShell grammar Name is classified as entity.name.function.invocation.powershell.
image

On VSC with no extensions >1.27.2, using a more recent version of the PowerShell grammar Name is classified as variable.other.member.powershell
image

Was this change intentional? It changes the way the code looks in VS Code since the built in themes don't use variable.other.memeber

Copied from original issue: Microsoft/vscode#68910

Dominant language
PowerShell
Stars
151
Forks
55
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/EditorSyntax

All issues in PowerShell/EditorSyntax

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.