Question: Interest in replacing build-grammar.js with a purely PowerShell solution?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript, powershell
- Domain
- build-system, tooling
Research direction
Start by comparing tools/build-grammar.js with the referenced build_grammar.ps1 and the PwshReadXmlPList implementation. Check whether their generated JSON and PowerShell version requirements match the existing build behavior. The issue is a proposal, so completion criteria and maintainer direction are not established.
Written by the indexing model from the issue text.
Description
Would there be any interest in replacing the build-grammar.js script (in tools) with a purely PowerShell based solution? I have created a script/function/class that provides the equivalent of 'fast-plist' using the .NET XML reader and a PowerShell script (using a class) to 'ConvertFrom-Plist'.
Two caveats.
- For performance reasons, I used a class, due to the fact that the inner function is highly recursive. The class with static method improved performance in excess of 4:1. This limits to PowerShell 5.0+.
- In order to as closely match the formatting of the existing JSON file output, PowerShell 6.0+ is required, and a
-replaceoperation to replace the space indent with tabs.
Reference:
https://github.com/msftrncs/PwshReadXmlPList
https://github.com/msftrncs/EditorSyntax/blob/build_grammar.ps1/tools/build-grammar.ps1
- Dominant language
- PowerShell
- Stars
- 151
- Forks
- 55
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PowerShell/EditorSyntax
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
PowerShell/EditorSyntax#224 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
PowerShell/EditorSyntax#222 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
PowerShell/EditorSyntax#221 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
PowerShell/EditorSyntax#220 · 2 comments · 1 reaction ·
-
Issue-Bug
Difficulty 3/5 1-2 days Newbie friendliness 48/100
PowerShell/EditorSyntax#219 · 2 comments ·
All issues in PowerShell/EditorSyntax
Similar issues
-
kind/bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/prow#953 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
zephyrproject-rtos/zephyr#119726 ·
-
out-of-date
Difficulty 1/5 Under an hour Newbie friendliness 82/100
CachyOS/CachyOS-PKGBUILDS#1894 ·
-
comp/dashboard P3 type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
NousResearch/hermes-agent#117722 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 92/100
objectionary/jeo-maven-plugin#1760 ·