The "scope" named "variable.other.member" includes the dot separator

Open
#131 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
powershell
Domain
tooling

Research direction

Reproduce the scope coloring in VS Code using the provided editor.tokenColorCustomizations and the examples $file.Length and $file.Delete(). Inspect the syntax scopes assigned to the dot, property name, and method call; done means variable.other.member no longer includes the separator or colors the method.

Written by the indexing model from the issue text.

Description

First off: I think we should be lexing a property and a method rather than the generic member -- however, this bug is simply against the fact that the separator dot is being included in the scope.

I'm using VS Code 1.26.0-insider

For repro sake, I added this to my preference:

    "editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "scope": "variable.other.member",
                "settings": {
                    "foreground": "#e23de2"
                }
            },
        ]
    },

And got this:

image

I expected only the words to be pink, i.e. only "Length" not ".Length" in:

$file.Length

I also did not expect it to affect the color of the method Delete() in

$file.Delete()
Dominant language
PowerShell
Stars
151
Forks
55
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/EditorSyntax

All issues in PowerShell/EditorSyntax

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.