numeric file size modifier scope

Open
#111 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
powershell
Domain
devtools

Research direction

Start by locating the PowerShell syntax definition that scopes numeric literals and compare its handling of the 1024mb sample with related syntax definitions. Done means the file-size unit receives a numeric file-size modifier scope rather than keyword.other, with any relevant syntax tests updated or passing.

Written by the indexing model from the issue text.

Description

scope-change
Environment
  • Sublime 3176
  • Monokai
Issue Description

Number modifiers are given a keyword.other scope, rather than something more appropriate.

Screenshots

image

Expected Behavior

the file size units modifier of the number is not a keyword, so it should receive a scope like storage.modifier.numeric.file-size instead of keyword.other, to be more consistent with other syntaxes

Code Samples
$file_size = 1024mb
Dominant language
PowerShell
Stars
151
Forks
55
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/EditorSyntax

All issues in PowerShell/EditorSyntax

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.