Highlighting for strings with "$(...)" is inconsistent

Open
#106 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
powershell
Domain
tooling

Research direction

Start by reproducing the highlighting difference with the provided PowerShell sample in Sublime using the Default theme, then inspect the repository's syntax grammar for string interpolation and $(...) expressions. Done means the expression inside the string is highlighted the same way as the equivalent expression outside it, without regressing surrounding string highlighting.

Written by the indexing model from the issue text.

Description

bug

Moved from https://github.com/SublimeText/PowerShell/issues/66

Environment
  • Editor and Version (VS Code, Atom, Sublime): Sublime
  • Your primary theme: Default
Issue Description

$(...) inside a string is an expression interpolation.
Ideally it should be highlighted exectly the same way as it's highlighted when put outside of the string context.
I'm not sure it's possible to achive with regex grammar.

Screenshots

Sublime -- difference between interpolated and non-interpolated
image

Expected Behavior

PowerShell_ISE -- both are the same
image

Code Samples
"blablabla $(invoke-foo baz $a.bar) blablabla"
invoke-foo baz $a.bar
Dominant language
PowerShell
Stars
151
Forks
55
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/EditorSyntax

All issues in PowerShell/EditorSyntax

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.