PostHog / PostHog/posthog

Bug report: Funnels - Problems with step order menus in historical trends

Open
#46,052 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug feature/funnels feature/insights team/product-analytics
Dominant language
Python
Stars
39.9k
Forks
3.4k
Avg merge
6h 51m
Merged PRs (30d)
232

Description

Bug Description

Please describe

In funnel insights, using graph type Historical trends, the menus for selecting steps for Conversion rate from --> to allow selecting a funnelFromStep which is greater than the selected funnelToStep. This causes the query to fail, and the user cannot return to editing the steps for conversation rate without first making changes to the query steps, then changing them back.

This occurs because the funnelFromStep menu continues displaying invalid options after the funnelToStep menu has been set to an earlier / lessor step. (e.g. After setting funnelToStep to Step 2, the invalid steps 3, 4, etc are still available on the funnelStepFrom menu.)

How to reproduce

  1. Create a funnel insight with 4 or 5 steps
  2. Set the graph type to Historical trends
  3. Set Conversion rate from to Step 4
  4. Set to to Step 2
  5. See the query error
  6. Try to return to editing the steps again.

Additional context

From: https://posthoghelp.zendesk.com/agent/tickets/47909 (moved to PostHog: https://us.posthog.com/project/2/support/tickets/50703)
(Includes a link to a narrated screen capture video)

Debug info
Debug info
Session: https://us.posthog.com/project/sTMFPsFhdP1Ssg/replay/019c009b-666a-7471-8fa8-8d0689580237?t=0
Admin: http://go/adminOrgEU/018a0740-290a-0000-4e10-4731a26ca5f7 (project ID 8178)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the report. Reproduce the issue in a funnel insight using the Historical trends graph and inspect the step-selection entry point; done means the “from” menu no longer offers steps after the selected “to” step and the query remains editable without an error.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
analytics, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.