Bring back `FromPyObject` implementations for structs wrapping `&str` references once the second lifetime is added to the trait in pyo3
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 642
- Forks
- 70
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 21
Description
With the Bound changes in pyo3, it is currently no longer possible to get a &str reference with a named lifetime in FromPyObject implementations which means we had to introduce a bunch of extra wrapper structs to deal with this. Once https://github.com/PyO3/pyo3/pull/4390 is merged and released, we should remove those again.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading upstream pyo3 PR #4390 and confirming that its second lifetime is released. Then locate the extra wrapper structs and their FromPyObject implementations for &str references, and remove the obsolete wrappers once the dependency is available. Done means those wrappers are no longer needed and the Rust/Python bindings still work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, rust
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100