Pometry / Pometry/Raphtory

Remove explicit conversion to NodeRef in GqlGraph associated functions if they are not needed

Open
#1,829 0 comments 0 reactions 1 assignee View on GitHub

@ricopinazo is already working on this.

Since Dec 9, 2024.

Dominant language
Rust
Stars
642
Forks
70
Avg merge
2d 13h
Merged PRs (30d)
21

Description

If you go to raphtory-graphql/src/mode/graph/graph.rs you will find that for many functions, such as subgraph_id, we are explicitly converting to NodeRef instead of using the node objects directly. Is this really necessary or can we skip that?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.