`AsNodeRef` as currently implemented encourages problems, can insert node that is not local to the graph
Open
@fabianmurariu is already working on this.
Since Aug 8, 2024.
Rust Core
- Dominant language
- Rust
- Stars
- 642
- Forks
- 70
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 21
Description
`AsNodeRef` as currently implemented encourages problems as it means that if we use a node from a different graph to insert it into an existing graph, it will use the local id which is likely nonsense. We should fix this in `NodeRef` so it keeps the NodeView around when created from a node which now should allow us to check if the node is local to the graph or not and act accordingly.
Originally posted by @ljeub-pometry in https://github.com/Pometry/Raphtory/pull/1695#discussion_r1691361991
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.