Document window parenting differences between FileDialog and AsyncFileDialog on macOS
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 830
- Forks
- 108
- Avg merge
- 6d 33m
- Merged PRs (30d)
- 2
Description
Since #58 added parenting support to FileDialog for macOS, we at least have somewhat decent behavior when setting a parent window. My testing is done on macOS 13.0.1.
With AsyncFileDialog, I get the behavior described in the PR thread:
I observe it working similarly to how it works without setting the child, except that when you move the parent window, the child moves along with it as a window group.
With FileDialog, I get the same behavior, except the dialog is never created centered on the parent. It's always created in the lower-left corner of my screen and as a result it doesn't feel like the parenting is working at all.
These differences should be documented in the API docs so that no one has to dig through closed GitHub issues to find out there is a difference and the historical reasons for it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the API documentation for FileDialog and AsyncFileDialog, then review the parenting behavior described here and the context from #58. Document their different macOS window-parenting behavior and the historical reasons noted in the referenced PR thread; done means users can understand the difference without searching closed issues.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100