PolyMeilex / PolyMeilex/rfd

windows: Dialog level icon is based on a workaround

Open
#78 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement good first issue help wanted
Dominant language
Rust
Stars
830
Forks
108
Avg merge
6d 33m
Merged PRs (30d)
2

Description

To quote #77:

TD_WARNING_ICON / TD_ERROR_ICON / TD_INFORMATION_ICON are missing so I use hard code to workaround.

This should be removed once https://github.com/microsoft/win32metadata/issues/968 is fixed and released

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the dialog icon implementation associated with issue #77 and check the linked win32metadata issue #968. Confirm that the upstream metadata fix has been released before removing the workaround; done means the hard-coded icon handling is no longer needed and dialog levels still use the correct icons.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
desktop
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.