PolyMeilex / PolyMeilex/Neothesia
Input manager doesn't tear down connections before creating new ones
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 1.5k
- Forks
- 115
- Avg merge
- 7h 48m
- Merged PRs (30d)
- 8
Description
While using the visualizer, I noticed that the visualizer would detect keyboard input on every other entry into the playing scene. Looking at the code, it became clear that the input manager was attempting to reconnect on every scene change, but was never actually explicitly disconnecting. This is likely what is leading to the flakey behavior, which for me is 100% reproducible. Steps to reproduce:
- start the app
- select a midi file
- click the "play" button to navigate to the
playing_scene// input at this point behaves normally - hit the "back" button to return to the
menu_scene. - hit the "play" button again to return to the
playing_scene// inputs no longer work
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the input manager and trace its connection setup across transitions between menu_scene and playing_scene. Reproduce the listed navigation steps, then verify that keyboard input still works after returning to the menu and entering the playing scene again.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100