PolicyEngine / PolicyEngine/policyengine-uk
Document treatment of `-1` in FRS tax/benefit amount columns
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 50
- Forks
- 33
- Avg merge
- 20h 58m
- Merged PRs (30d)
- 14
Description
Following up on https://github.com/PolicyEngine/openfisca-uk-data/issues/71#issuecomment-1016616474
We might also want to explore treating them differently than zero, i.e. if -1 indicates missing, we should probably overwrite it with the calculated value with greater probability than those that report zero (maybe 100%).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked openfisca-uk-data discussion and determine what -1 means in FRS tax and benefit amount columns. Document the agreed treatment and whether calculated values should overwrite -1 differently from reported zero; the issue names no project file or test, so the relevant documentation location must first be identified.
Written by the indexing model from the issue text.
Assessment
- Domain
- data, documentation
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100