PolicyEngine / PolicyEngine/policyengine-core
Remove duplicate reform application
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 22
- Forks
- 30
- Avg merge
- 14h 33m
- Merged PRs (30d)
- 7
Description
We currently apply reforms twice- once at the tax-benefit system initialisation, once afterwards. This doesn't affect the vast majority of simulations, but where reforms e.g. add a new parameter without checking the old one, it breaks. I think we should remove the second application.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the tax-benefit system initialization and the later reform application path to locate where reforms are applied twice. Run the existing simulation and reform tests, then confirm that reforms are applied once and that cases adding parameters without checking prior definitions no longer fail.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100