PolicyEngine / PolicyEngine/policyengine-core

Type of parameter should be asserted if thresholds/rates/amounts are present

Open
#217 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
22
Forks
30
Avg merge
14h 33m
Merged PRs (30d)
7

Description

We currently ran into the issue in the US repo where a scale parameter did not have the proper metadata and was returning 0 as opposed to errors

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked PolicyEngine US pull request and trace how scale parameters with thresholds, rates, or amounts are validated in policyengine-core. Identify the parameter metadata entry point and existing validation tests, then confirm that missing or incorrect type metadata raises an error instead of producing 0.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.