PolicyEngine / PolicyEngine/policyengine-app-v2

Rename 'Create simulation' to 'Create baseline' for baseline simulation step

Open
#734 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
1
Forks
3
Avg merge
1d 50m
Merged PRs (30d)
39

Description

Context

User feedback from Greg Miller (Land Economics) while using the report creation flow for Maine property tax reform analysis.

Problem

When creating a report, the first simulation step shows "Create simulation" as the page title and button text. Greg got confused thinking he was supposed to create the policy change here, and ended up creating a baseline and reform that were identical.

The system already knows whether it's the baseline (index 0) or reform (index 1) — the default labels use "baseline simulation" vs "reform simulation" — but the page title and buttons don't reflect this.

Suggested fix

Make the titles/buttons context-aware based on simulationIndex:

  • SimulationLabelView.tsx (line 83): Change title from "Create simulation" to simulationIndex === 0 ? "Create baseline" : "Create reform"
  • SimulationSubmitView.tsx (line 84): Same pattern for submit button text (needs simulationIndex prop threaded through)
  • SimulationLabelView.tsx (line 77): Button label "Initialize simulation""Initialize baseline" / "Initialize reform"

Screenshot from Greg's email

He highlighted the "Create simulation" button area as the source of confusion.

Files

  • app/src/pathways/report/views/simulation/SimulationLabelView.tsx
  • app/src/pathways/report/views/simulation/SimulationSubmitView.tsx
  • app/src/pathways/report/ReportPathwayWrapper.tsx (needs to pass simulationIndex to SimulationSubmitView)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with SimulationLabelView.tsx and SimulationSubmitView.tsx, then inspect ReportPathwayWrapper.tsx to follow how simulationIndex reaches the submit view. The work is done when the title and buttons show baseline for index 0 and reform for index 1 throughout the report creation flow.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.