PolicyEngine / PolicyEngine/microcosm

By-origin battery

Open
#781 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
0
Forks
4
Avg merge
1d 3h
Merged PRs (30d)
94

Description

Defect

Two QBI booleans — business_is_sstb and SSTB-qualification — are deterministically failing by-origin battery comparisons: QBI reconciliation intentionally clears these flags on clone 0 because base ASEC lacks frozen PUF QBI observations (qbi_inputs.py:1228), while the battery registry hardcodes clone-0 comparisons (stacked_spine.py:3015) and the comparator deliberately fails zero/zero booleans (stacked_spine.py:13660).

Evidence this is clone-role incompatibility, not absence: processed PUF source positives are ~31.6k/30.7k for the two flags, final clone-1 positives ~37.9k/37.6k — clone 0 alone is intentionally zero.

These two comparisons cannot pass under the current contract on any build, at any scale. They appear as 2 of the 78 failure reasons in the 25% candidate gates receipt and in every 1% diagnostic.

Fix direction (owner adjudication)

Either register these targets against the clone that owns them, or give zero/zero-with-populated-sibling-clone comparisons an explicit non-fatal status. Adjudicated spec change, not a tolerance tweak.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading qbi_inputs.py:1228 and the clone-0 battery registration in stacked_spine.py:3015, then inspect the zero/zero comparator at stacked_spine.py:13660 and reproduce the two failures in the candidate-gates receipt. Done means the clone-role contract is adjudicated and these comparisons no longer appear as deterministic failure reasons, with the relevant battery diagnostics confirming the result.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data, testing-qa
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.