PolicyEngine / PolicyEngine/microcosm-dynamics
Post-lock hygiene from the round-3 referee's non-blocking notes
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1
- Forks
- 1
- Avg merge
- 1h 46m
- Merged PRs (30d)
- 28
Description
The round-3 referee ratified the gate-1 lock (PR #33, comment 4885159605) with non-blocking notes, deliberately left out of the lock to avoid re-refereeing a converged pre-registration. None changes a locked threshold; all are hygiene on the machinery around it. Land after the lock merges:
- Derivations test: assert mean/sd consistency with the values arrays.
tests/test_gates_derivations.pybinds thresholds to artifactmean/sdfields, but a hand-editedmean/sdwith an intactvalues[]would pass unnoticed. Add an assertion that each floor stat'smean/sdequals the recomputed statistics of itsvaluesarray (ddof=1), for every artifact cited by aderivations.floor_run. - Remove the stale round-1-era motivation clause at gates.yaml lines ~43-49 (pre-amendment text describing the runs view as the chained-model catch; superseded by the persistence-attribution note in the gate-1 block).
- Declare computed-but-ungated quantities. The runs view's energy/tail stats, the change-moment mean, and
transition_ratesare computed by the harness but neither locked nor listed inreported_not_gated. List them there explicitly so nothing is silently ungated.
Context: rounds 1-3 of the pre-lock review are comments 4884803805, 4885102386, 4885159605 on PR #33.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tests/test_gates_derivations.py and the referenced derivations.floor_run artifacts; run the existing derivation tests before changing them. Then inspect gates.yaml around lines 43-49 and the gate-1 block. Done means consistency assertions cover every cited artifact, stale motivation text is removed, and the listed computed quantities appear in reported_not_gated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 66/100