max_turns fields null for consecutively executed moves, and populated based on move ailments
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5.4k
- Forks
- 1.2k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 21
Description
Consecutively executed moves - such as Rollout or Ice Ball, which strike for a number of turns in a row - currently show null in the max_turns field inside the move metadata. I looked through the moves that do have values in this field, and it seems it is instead being used to show - for only some moves that can/do cause ailments, e.g. Sing and Grass Whistle - the min and max turns that the resulting ailment can last for. Is this intended behaviour? The documentation seems to suggest that that field would be utilised for consecutively executed moves. If that is the case, it may be true that there would likely need to be a 'past_values' field or a field similarly named, since some of these moves change in the number of turns they are limited to across generations.
Consecutively executed moves can be found here: https://bulbapedia.bulbagarden.net/wiki/Category:Consecutively_executed_moves
Hope this makes sense, and thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by comparing move metadata for consecutively executed moves with moves that populate max_turns for ailments, then check the documentation referenced by the issue. Done requires a decided meaning for max_turns and consistent metadata or documentation for the affected moves and generations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100