Genus data for forms is missing
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5.4k
- Forks
- 1.2k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 21
Description
Hello, first off, thanks for the maintenance of this amazing project. It's such a useful learning tool.
I've been exploring the new GraphQL API over the last few days for a little project I'm working on.
I've noticed that genus is only returned at the species level. This is fine for most cases, but there are some Pokemon whose genus changes depending on their form. I expectedpokemonforms to return a form-specific genus.
Some examples of Pokémon where this happens:
- Rapidash
Fire Horse->Unique Horn - Typhlosion
Volcano->Ghost Flame - Slowking
Royal->Hexpert
I've linked to Bulbapedia there, but pokemondb.net has the correct form/genus values as well.
Am I missing something? I pulled the repo and did a global search for the correct values but can't see them in any of the CSV files.
Happy to help fix this if I can! Thanks ☺️
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the GraphQL API's pokemonforms response and tracing the repository data sources; the issue notes that the relevant values are absent from the CSV files and points to pokemon-forms.yaml as a reference. Done means form-specific genus values are returned for cases such as Rapidash, Typhlosion, and Slowking.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- graphql, python
- Domain
- api, data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100