PokeAPI / PokeAPI/pokeapi

Magmar & Pichu have Follow Me in their Move Data by Machine (TM's) while the move follow me has never been a TM

Open
#1,188 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5.4k
Forks
1.2k
Avg merge
2d 5h
Merged PRs (30d)
21

Description

When asking the API for the data for a few Pokémon I came across an issue where TM data for a move which never has been a TM was provided for 2 Pokémon. These Pokémon being Pichu and Magmar. After searching a bit, I came across commit: a57ebeff66bae380fb0f4c4eb4790bc85c1256b2

This commit has added the move to 3 Pokémon. But on 2 of these (Magmar, Pichu) it was added under move-learn-method : 4 which is "Machine"

Steps to Reproduce: (Pichu)

  1. Go to https://pokeapi.co/api/v2/pokemon/pichu
  2. Go to Moves/54
  3. This is where the Move "Follow me" is defined as TM for Fire Red / Leaf Green

Steps to Reproduce: (Magmar)

  1. Go to https://pokeapi.co/api/v2/pokemon/magmar
  2. Go to Moves/67
  3. This is where the Move "Follow me" is defined as TM for Colosseum

Expected Behavior:
When asking the API for the TM/HM data for Magmar and Pichu, it shouldn't include Follow Me

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with commit a57ebeff66bae380fb0f4c4eb4790bc85c1256b2 and compare the move entries returned by the Pichu and Magmar API endpoints. Check the referenced Moves/54 and Moves/67 entries, then verify that Follow Me is no longer listed as a Machine move for Fire Red / Leaf Green or Colosseum.

Written by the indexing model from the issue text.

Assessment

Domain
api, data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.