Encounters seem incomplete for gen3, missing npc trades
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5.4k
- Forks
- 1.2k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 21
Description
It seems that npc trades are not in the encounters data for at least the gen3 games.
Steps to Reproduce:
query samplePokeAPIquery {
pokemon_v2_version(where: {id: {_eq: 10}}) {
name
id
pokemon_v2_encounters {
pokemon_v2_encounterslot {
pokemon_v2_encountermethod {
name
}
}
}
}
}
- Observe there are no npc trades, despite there being npc trades within the game to get certain pokemon.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the pokemon_v2_encounters data behind the provided GraphQL query for gen3 games and compare it with the NPC trades available in those games. The work is done when the relevant NPC trades are represented in the encounters data and the sample query returns them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- graphql
- Domain
- api, database
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100